Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfile not up to date in 0.14.3 tag #556

Closed
alerque opened this issue Aug 27, 2022 · 2 comments
Closed

Lockfile not up to date in 0.14.3 tag #556

alerque opened this issue Aug 27, 2022 · 2 comments

Comments

@alerque
Copy link

alerque commented Aug 27, 2022

The Cargo.lock file in the last tagged release 0.14.3 is not up to date with Cargo.toml. This breaks distro packaging that target reproducible builds. We can of course get it to build without using --locked but then the build is not reproducible (among other possible issue).

Please make sure the lockfile is refreshed before each tagged release (if not every time Cargo.toml is updated).

@JohnnyMorganz
Copy link
Owner

Yeah, I forgot to update it this release, so unfortunately had to do it in a commit aftwards. Will try to fix this

@JohnnyMorganz
Copy link
Owner

This has been fixed for 0.15.0 and future releases. I've added some checks to ensure this doesn't happen again, so I'll close this issue now.

Let me know if anything specific needs to be done for the 0.14.3 release though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants