Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Rename non local Functions or variables #568

Closed
kalebs-anotheraxiom opened this issue Mar 5, 2024 · 1 comment
Closed

Unable to Rename non local Functions or variables #568

kalebs-anotheraxiom opened this issue Mar 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kalebs-anotheraxiom
Copy link

kalebs-anotheraxiom commented Mar 5, 2024

When declaring non local Functions as shown below, Or non local variables, you are unable to use F2 Rename to rename the function and or any references

Code_CGUINjKu3K

I have a local fix creating a new FindGlobalReferences Luau::AstVisitor and a new findGlobalReferences function inside of LuauExt.cpp which is used as a fallback because non local types have some sort of discrepancy when it comes to exprOrLocal inside of the Rename Operation, It was a bit hacked together so i don't want to open a Pr with it but I could provide my source as a starting point for a fix

@JohnnyMorganz JohnnyMorganz added the bug Something isn't working label Mar 5, 2024
@JohnnyMorganz
Copy link
Owner

Thanks for the info! Will try to take a look this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants