Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'svn.sourceControl.ignore' option #1116

Merged
merged 4 commits into from
Nov 8, 2020

Conversation

Faputa
Copy link
Contributor

@Faputa Faputa commented Oct 26, 2020

Link #1113

Add svn.sourceControl.ignore option, It can ignore unversioned files like .gitignore. At the same time, configuring this option will overlook the default svn ignore rule, but if you do not configure this option, nothing will change.

In addition, I found that when revert multiple added files, if the files are of parent-child structure, the plugin will report an error. To solve this problem just need to reverse the order of the file list.

@JohnstonCode JohnstonCode self-requested a review October 26, 2020 09:08
@Faputa
Copy link
Contributor Author

Faputa commented Nov 2, 2020

I found that this pull request has no intention to be merged. Is there any problem?

@JohnstonCode
Copy link
Owner

No problem, just lack of time currently. Will try to have a look this week.

@@ -26,7 +26,7 @@ export class Revert extends Command {
return;
}

const paths = resources.map(resource => resource.fsPath);
const paths = resources.map(resource => resource.fsPath).reverse();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@@ -26,7 +26,7 @@ export class RevertAll extends Command {
return;
}

const paths = resources.map(resource => resource.fsPath);
const paths = resources.map(resource => resource.fsPath).reverse();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JohnstonCode JohnstonCode changed the title Add ignore option feat: Add 'svn.sourceControl.ignore' option Nov 8, 2020
@JohnstonCode JohnstonCode merged commit 7b4241b into JohnstonCode:master Nov 8, 2020
@Faputa
Copy link
Contributor Author

Faputa commented Nov 8, 2020

Thanks.

JohnstonCode added a commit that referenced this pull request Nov 8, 2020
# [2.13.0](v2.12.4...v2.13.0) (2020-11-08)

### Features

* Add 'svn.sourceControl.ignore' option ([#1116](#1116)) ([7b4241b](7b4241b))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Faputa Faputa deleted the add-ignore-option branch November 9, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add svn.sourceControl.ignore option to Ignore unversioned files like .gitignore
2 participants