Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing dependency: iconv-lite #1558

Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix: Missing dependency: iconv-lite #1558

merged 1 commit into from
Feb 4, 2022

Conversation

klren0312
Copy link
Contributor

fix: #973 (comment)
image

Version: 1.64.0-insider (user setup)
Commit: 7ae7f9d40b82a0f1a49d8ad180d27e16812ad95e
Date: 2022-01-18T05:16:47.915Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.18363

@metal571 metal571 mentioned this pull request Feb 3, 2022
Closed
@JohnstonCode
Copy link
Owner

Sorry i missed this. It got lost in the smap i get from github.

@JohnstonCode JohnstonCode merged commit d614c2a into JohnstonCode:master Feb 4, 2022
JohnstonCode added a commit that referenced this pull request Feb 4, 2022
@JohnstonCode
chore(release): 2.15.3 [skip ci]
6b8f193 
## [2.15.3](v2.15.2...v2.15.3) (2022-02-04)

### Bug Fixes

* Missing dependency: iconv-lite ([#1558](#1558)) ([d614c2a](d614c2a))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.15.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@klren0312 klren0312 deleted the fixbug/iconv-lite-umd branch February 6, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency, go to and run: npm install iconv-lite
2 participants
@klren0312 @JohnstonCode