Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed jschardet and iconv-lite from vsix #409

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Conversation

edgardmessias
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #409 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   61.83%   61.86%   +0.03%     
==========================================
  Files         170      170              
  Lines        7182     7188       +6     
  Branches     1359     1359              
==========================================
+ Hits         4441     4447       +6     
  Misses       2737     2737              
  Partials        4        4
Impacted Files Coverage Δ
src/svn.ts 87.5% <100%> (+0.37%) ⬆️
out/svn.js 88.39% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335bf3c...4f2006c. Read the comment docs.

@JohnstonCode
Copy link
Owner

Nice little trick you are using.

@JohnstonCode JohnstonCode merged commit 710090a into master Nov 13, 2018
@JohnstonCode JohnstonCode deleted the reduce_vsix branch November 13, 2018 19:07
JohnstonCode added a commit that referenced this pull request Nov 13, 2018
## [1.45.2](v1.45.1...v1.45.2) (2018-11-13)

### Bug Fixes

* Removed jschardet and iconv-lite from vsix ([#409](#409)) ([710090a](710090a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants