Fix commit icon for undefined author #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a commit has no author defined, getCommitIcon would finally crash at creating the md5 of undefined. With this patch the non-gravatar default icon is used instead, for commits with an undefined author.
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 57.12% 56.95% -0.18%
==========================================
Files 117 117
Lines 4397 4398 +1
Branches 646 635 -11
==========================================
- Hits 2512 2505 -7
- Misses 1653 1659 +6
- Partials 232 234 +2
Continue to review full report at Codecov.
|
JohnstonCode
added a commit
that referenced
this pull request
Jul 1, 2019
## [1.54.3](v1.54.2...v1.54.3) (2019-07-01) ### Bug Fixes * Commit icon for undefined author ([#626](#626)) ([85c07e4](85c07e4))
|
🎉 This PR is included in version 1.54.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a commit has no author defined, getCommitIcon would finally crash
at creating the md5 of undefined. With this patch the non-gravatar
default icon is used instead, for commits with an undefined author.