Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: diff files now have unique paths #694

Merged
merged 13 commits into from
Oct 28, 2019
Merged

fix: diff files now have unique paths #694

merged 13 commits into from
Oct 28, 2019

Conversation

JohnstonCode
Copy link
Owner

fixes #658

@codecov
Copy link

codecov bot commented Oct 27, 2019 •
edited
Loading

Codecov Report

Merging #694 into master will increase coverage by 0.33%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage    56.2%   56.53%   +0.33%     
==========================================
  Files         117      117              
  Lines        4402     4408       +6     
  Branches      649      650       +1     
==========================================
+ Hits         2474     2492      +18     
+ Misses       1690     1680      -10     
+ Partials      238      236       -2
Impacted Files Coverage Δ
src/tempFiles.ts 100% <100%> (+41.66%) ⬆️
src/historyView/common.ts 33.09% <33.33%> (ø) ⬆️
src/svnContentProvider.ts 50.68% <0%> (-1.37%) ⬇️
src/model.ts 60.25% <0%> (+0.41%) ⬆️
src/repository.ts 61% <0%> (+0.65%) ⬆️
src/resource.ts 53.27% <0%> (+0.93%) ⬆️
src/commands/command.ts 51.25% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2f922...29dd3df. Read the comment docs.

@edgardmessias
Copy link
Contributor

Why no use the tmp library? https://www.npmjs.com/package/tmp

@JohnstonCode
Copy link
Owner Author

I dont think using it gives any advantage, the code is concise already. The only benefit of the tmp library is the clenup. But in this situation it is extra effort to check when the file is no longer in use.

edgardmessias
edgardmessias previously approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@edgardmessias edgardmessias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, If possible, replace snvUri with svnUri

@JohnstonCode
Copy link
Owner Author

While im at it i will rename the function to somethnig more useful and add some tests. Maybe createTempSvnRevisionFile

@JohnstonCode JohnstonCode merged commit 0ff8666 into master Oct 28, 2019
@JohnstonCode JohnstonCode deleted the 658 branch October 28, 2019 20:46
github-actions bot pushed a commit that referenced this pull request Oct 28, 2019
@JohnstonCode
chore(release): 1.54.8 [skip ci]
eac3cac 
## [1.54.8](v1.54.7...v1.54.8) (2019-10-28)

### Bug Fixes

* diff files now have unique paths ([#694](#694)) ([0ff8666](0ff8666))
@JohnstonCode
Copy link
Owner Author

🎉 This PR is included in version 1.54.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 28, 2019
@JohnstonCode
chore(release): 1.54.8 [skip ci]
aa2cc75 
## [1.54.8](v1.54.7...v1.54.8) (2019-10-28)

### Bug Fixes

* diff files now have unique paths ([#694](#694)) ([0ff8666](0ff8666))
JohnstonCode added a commit that referenced this pull request Oct 28, 2019
@JohnstonCode
chore(release): 1.54.8 [skip ci]
ce777a5 
## [1.54.8](v1.54.7...v1.54.8) (2019-10-28)

### Bug Fixes

* diff files now have unique paths ([#694](#694)) ([0ff8666](0ff8666))
JohnstonCode added a commit that referenced this pull request Oct 29, 2019
@JohnstonCode
chore(release): 1.54.8 [skip ci]
f22b81b 
## [1.54.8](v1.54.7...v1.54.8) (2019-10-29)

### Bug Fixes

* diff files now have unique paths ([#694](#694)) ([0ff8666](0ff8666))
JohnstonCode added a commit that referenced this pull request Oct 29, 2019
@JohnstonCode
chore(release): 1.54.8 [skip ci]
a484ef6 
## [1.54.8](v1.54.7...v1.54.8) (2019-10-29)

### Bug Fixes

* diff files now have unique paths ([#694](#694)) ([0ff8666](0ff8666))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgardmessias edgardmessias edgardmessias approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong revision diff file with files with the same name
2 participants
@JohnstonCode @edgardmessias