-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add remove unversioned command #769
Conversation
And this feature is available only since 1.9 |
I think the better solution would be to set vscode-variable svn_gt_1_9 to true or false and depending on that show or hide commands, but since |
My local prettylint does not complain about src/test/testUtil.ts, it actually has fixed it. ver 1.0.0 |
A better way would be to create a svn version context and then do a check on that |
done The problem with prettylint is actually with bash globbing |
Can you check that the changes i have made are working for you? |
Yep, working fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# [2.4.0](v2.3.0...v2.4.0) (2020-01-07) ### Features * Add remove unversioned command ([#769](#769)) ([177bb0b](177bb0b))
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The only thing that I would like to discuss with you is
logOutput
. I've made it public since I think we must inform user whatever actually happened.I propose a global function, maybe in utils, which will log everything to outputChannel. Under the hood it will emit events, which output channel will be subscribed to.