Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add remove unversioned command #769

Merged
merged 7 commits into from
Jan 7, 2020

Conversation

Yanpas
Copy link
Contributor

@Yanpas Yanpas commented Jan 2, 2020

The only thing that I would like to discuss with you is logOutput. I've made it public since I think we must inform user whatever actually happened.

I propose a global function, maybe in utils, which will log everything to outputChannel. Under the hood it will emit events, which output channel will be subscribed to.

@Yanpas
Copy link
Contributor Author

Yanpas commented Jan 3, 2020

And this feature is available only since 1.9

@Yanpas
Copy link
Contributor Author

Yanpas commented Jan 4, 2020

I think the better solution would be to set vscode-variable svn_gt_1_9 to true or false and depending on that show or hide commands, but since Svn is not singleton I decided to do it in this way

@Yanpas
Copy link
Contributor Author

Yanpas commented Jan 4, 2020

My local prettylint does not complain about src/test/testUtil.ts, it actually has fixed it. ver 1.0.0

@JohnstonCode
Copy link
Owner

A better way would be to create a svn version context and then do a check on that

@Yanpas
Copy link
Contributor Author

Yanpas commented Jan 6, 2020

done

The problem with prettylint is actually with bash globbing

@JohnstonCode JohnstonCode self-requested a review January 7, 2020 09:30
@JohnstonCode
Copy link
Owner

Can you check that the changes i have made are working for you?

@Yanpas
Copy link
Contributor Author

Yanpas commented Jan 7, 2020

Yep, working fine

Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnstonCode JohnstonCode changed the title Add remove unversioned command, fixes #557 feat: Add remove unversioned command Jan 7, 2020
@JohnstonCode JohnstonCode merged commit 177bb0b into JohnstonCode:master Jan 7, 2020
JohnstonCode added a commit that referenced this pull request Jan 7, 2020
# [2.4.0](v2.3.0...v2.4.0) (2020-01-07)

### Features

* Add remove unversioned command ([#769](#769)) ([177bb0b](177bb0b))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Yanpas Yanpas deleted the rm_unv_557 branch January 7, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants