Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed repeated auths prompt (close #652) #799

Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix: Fixed repeated auths prompt (close #652) #799

merged 1 commit into from
Feb 11, 2020

Conversation

edgardmessias
Copy link
Contributor

Instead of find a way to save auth, use keytar as an alternative.

See: https://code.visualstudio.com/api/advanced-topics/remote-extensions#persisting-secrets

@edgardmessias
Copy link
Contributor Author

I no know, we need be a test, because keytar depends of system libs.

Need test with and without gnome-keyring

JohnstonCode
JohnstonCode approved these changes Feb 11, 2020
View reviewed changes
Copy link
Owner

@JohnstonCode JohnstonCode left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working for me with gnome-keyring and without libsecret-devel

@JohnstonCode
Copy link
Owner

Let me know if you're happy to merge

@edgardmessias
Copy link
Contributor Author

I'm happy, lol

@JohnstonCode JohnstonCode merged commit 42e64a9 into JohnstonCode:master Feb 11, 2020
JohnstonCode added a commit that referenced this pull request Feb 11, 2020
@JohnstonCode
chore(release): 2.6.2 [skip ci]
ab36458 
## [2.6.2](v2.6.1...v2.6.2) (2020-02-11)

### Bug Fixes

* Fixed repeated auths prompt (close [#652](#652)) ([#799](#799)) ([42e64a9](42e64a9))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edgardmessias edgardmessias mentioned this pull request Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edgardmessias @JohnstonCode