Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use remote URI to retrieve file for repo log #804

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

FractalBoy
Copy link
Contributor

This fixes being unable to diff a file between revisions due to sparse checkout. Instead of trying to figure out where the file lives on the filesystem, we'll simply use the remote URI to diff the file.

@JohnstonCode
Copy link
Owner

Looks good. @Yanpas you see any issues?

@JohnstonCode JohnstonCode self-requested a review February 14, 2020 10:01
Copy link
Contributor

@Yanpas Yanpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current implementation is cheaper in terms of calls to svn command. On the other hand the logic of finding previous path is messy, and may not handle cross-renames (file a moved to b and vice-versa) I guess. Finally the simpler code the better. Approve

@JohnstonCode JohnstonCode changed the title Use remote URI to retrieve file for repo log fix: Use remote URI to retrieve file for repo log Feb 14, 2020
@JohnstonCode JohnstonCode merged commit 35ac8db into JohnstonCode:master Feb 14, 2020
JohnstonCode added a commit that referenced this pull request Feb 14, 2020
## [2.7.1](v2.7.0...v2.7.1) (2020-02-14)

### Bug Fixes

* Use remote URI to retrieve file for repo log ([#804](#804)) ([35ac8db](35ac8db))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@FractalBoy FractalBoy deleted the use-remote-repo-for-diff branch December 20, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants