Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow select files to commit when choose "changes" (close #472) #811

Merged
merged 12 commits into from
Feb 19, 2020
Merged

feat: Allow select files to commit when choose "changes" (close #472) #811

merged 12 commits into from
Feb 19, 2020

Conversation

edgardmessias
Copy link
Contributor

@edgardmessias edgardmessias commented Feb 14, 2020 •
edited
Loading

image
image

I need update the tests

JohnstonCode
JohnstonCode requested changes Feb 15, 2020
View reviewed changes
Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to be broken

@JohnstonCode JohnstonCode linked an issue Feb 18, 2020 that may be closed by this pull request
Ctrl + Enter for commit doesn't give option to choose "Selected" files #472
Closed
@JohnstonCode JohnstonCode self-requested a review February 18, 2020 12:07
@JohnstonCode
Copy link
Owner

Should the default behaviour be to select all files?

@edgardmessias
Copy link
Contributor Author

I think better to create a option, and user can change the default behavior (default: None)

@JohnstonCode
Copy link
Owner

Would this be better as a separate command Select files to commit?

@edgardmessias
Copy link
Contributor Author

No, because you can select some files and use Commit selected

@JohnstonCode
Copy link
Owner

JohnstonCode commented Feb 18, 2020 •
edited
Loading

Okay, I also think the default open should be all. As that is the current behaviour

@JohnstonCode
Copy link
Owner

Add a config option and we are good

@edgardmessias
Copy link
Contributor Author

Ok, I will make the changes

@JohnstonCode JohnstonCode merged commit ba4e806 into JohnstonCode:master Feb 19, 2020
JohnstonCode added a commit that referenced this pull request Feb 19, 2020
@JohnstonCode
chore(release): 2.9.0 [skip ci]
032ece8 
# [2.9.0](v2.8.0...v2.9.0) (2020-02-19)

### Features

* Allow select files to commit when choose "changes" (close [#472](#472)) ([#811](#811)) ([ba4e806](ba4e806))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl + Enter for commit doesn't give option to choose "Selected" files
2 participants
@edgardmessias @JohnstonCode