-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a 'waiting mode' for cases where RPC calls are not functioning correctly? #699
Comments
Indeed, painstaking efforts were made some years ago to try to assure that all error conditions were handled, including timeouts. See: joinmarket-clientserver/jmclient/jmclient/jsonrpc.py Lines 150 to 160 in 7f85822
So if that isn't doing what it's intended to do, we, I guess, have a bug we need to fix (or handle an unanticipated case, let's say). I guess this is one of those things that's significantly harder to do because it has to be reproduced first. Can you get something reproducible (tough one, but if you can that might be our best shot). |
Your suggested fix of keeping the retry in |
Oh I see. That When I originally made this issue I was just vaguely assuming we had the 'connection timed out' case covered, because we had addressed so many cases. But it looks like, maybe not. |
See #673 (comment) as a summary of that thread as a whole, the commit which closed that thread did only the "easy" thing of shutting down, and the issue is rather tricky.
I want to strongly emphasize again, that a simple flakiness of network connection should already be handled by extensive Exception catching as well as multiple retries within jsonrpc.py already, this is only for special/unexpected failures.
The text was updated successfully, but these errors were encountered: