Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified merchant feature #333

Merged
merged 9 commits into from Nov 6, 2020
Merged

simplified merchant feature #333

merged 9 commits into from Nov 6, 2020

Conversation

7flash
Copy link
Collaborator

@7flash 7flash commented Oct 28, 2020

Allow merchant to create catalog of products, and easily create invoices with chosen products from catalog. In difference from #324 where we have separate screens for catalog, invoices and orders, - here we have single Receive screen with quick access through bottom sheets.

@7flash
Copy link
Collaborator Author

7flash commented Oct 28, 2020

merchant

@gguijarro-c-chwy
Copy link
Collaborator

Your build is broken.
info • Unused import: 'package:seeds/constants/app_colors.dart' • lib/screens/app/wallet/receive.dart:3:8 • unused_import

@gguijarro-c-chwy
Copy link
Collaborator

gguijarro-c-chwy commented Oct 28, 2020

8 Items in the merchant list Only 7 items show
image image

This list needs to scroll.

@gguijarro-c-chwy
Copy link
Collaborator

Looks like the app on open defaults to this screen.

I am no sure if this was done for testing purposes, but we should not merge test code into master.

@gguijarro-c-chwy
Copy link
Collaborator

gguijarro-c-chwy commented Oct 28, 2020

Once items are added to the invoice or list of products they can no longer be removed?

Padding(
padding: const EdgeInsets.fromLTRB(0, 33, 0, 0),
child: MainButton(
title: "Next",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing translation

Copy link
Collaborator

@gguijarro-c-chwy gguijarro-c-chwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature is cool, I think it needs some tweaks before merging it in.
I added a few questions.

Thanks

@7flash
Copy link
Collaborator Author

7flash commented Oct 29, 2020

merchant

@gguijarro-c-chwy
Copy link
Collaborator

Give the user taps on + to add a new item
Then selects an item from the list
When the user taps on the Navigation back button
The app DOES NOT navigate back, the back must be tapped as many times as items added in the list.

This is most likely a bug with navigation to the list and selecting an item.

@gguijarro-c-chwy
Copy link
Collaborator

There is no way to remove an item from the list once added. Are there plans to add this functionality ?

@gguijarro-c-chwy
Copy link
Collaborator

Are we planning on moving the list of items into a storage outside of the device?

@7flash
Copy link
Collaborator Author

7flash commented Oct 30, 2020

Give the user taps on + to add a new item
Then selects an item from the list
When the user taps on the Navigation back button
The app DOES NOT navigate back, the back must be tapped as many times as items added in the list.

This is most likely a bug with navigation to the list and selecting an item.

Thanks, fixed, just missed to remove empty bottom sheet

@7flash
Copy link
Collaborator Author

7flash commented Oct 30, 2020

There is no way to remove an item from the list once added. Are there plans to add this functionality ?

No, maybe later when necessary

@7flash
Copy link
Collaborator Author

7flash commented Oct 30, 2020

Are we planning on moving the list of items into a storage outside of the device?

Yes, planning to move either to firebase or blockchain (another feature)

Copy link
Collaborator

@gguijarro-c-chwy gguijarro-c-chwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n13 n13 merged commit 88c2666 into master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants