Refactoring Merchant Mode #432
Conversation
it's weird when we enter a price but don't even have a name yet...
This reverts commit db95c34.
|
Hi Nick, I was testing your recent commits and I found some bugs when Adding and removing products to be displayed. if an user try to delete a product it goes to negative instead of disappearing. Also when they click on a product to be added it wont take you to the receive screen and product is also added with a quantity of 0. |
|
I am not sure this receive + products feature is ready for users. The UI is so ugly it makes me throw up and the are so many bugs that i dont even know where to start. I think we should have jason design this feature and we should put some work on it. |
|
Will try to fix this up today Entry does seem to have a lot of bugs |
|
I saw those bugs too will check
β¦ On Jan 15, 2021, at 10:05 AM, gguij004 ***@***.***> wrote:
ο»Ώ
Hi Nick, I was testing your recent commits and I found some bugs when Adding and removing products to be displayed. if an user try to delete a product it goes to negative instead of disappearing. Also when they click on a product to be added it wont take you to the receive screen and product is also added with a quantity of 0.
β
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Maybe "edit Products " instead of "edit" by itself?
|
we dont need label? |
|
Receipt still have overflow error for small devices
|
|
We allow users to create negative products. not sure what will happen on this example. Maybe we can let then create negative products to use as discounts,
|
Yeah, this is no bueno. |
|
Negative is no good yes... |
No... edit is standard. Also would be too long for a button. |
Added hint text ... please consider this is an alpha feature we just want to enable people to start using it There will be a redesign
|
Fixed |
|
Small devices - changed layout We can either remove the image, or make the text smaller
|
|
Fixed negative entry - not allowed This happened because I refactored the amount field to be dual currency, to only have 1 implementation, and to be used everywhere, in transfer and also in entry here. So overall - my bad for not testing it properly, but not wasted time to get this right. Thanks for finding all these!
|
|
still broken for small device. not sure if we should looking into it since we are going to redesign feature.
|
Fixed |
Ok then, no pix on small devices ;) Fixed
|
|
Ummm whoa that's not a scroll view! Well - thanks! |
π Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Issue - Merchant mode had a strange UX and many bugs
Fix - redid merchant mode, split into multiple different screens as a good enough beta version.
Merged the ability to change the list order of merchant goods from Igor's PR
β Checklist
π΅οΈββοΈ Notes for Code Reviewer
Never mind so much about the code, just run through some basic UX testing if you wish - it's too much code to review
Many, many things were broken before so this is definitely better than what we had.
π Screenshots
Screen.480p.mov
π―ββοΈ Paired with
me myself and I