anchor integration #517

7flash · 2021-02-18T19:35:01Z

I created a ticket for this

[Nik here] Purpose to enable Seeds light wallet to sign transactions on the DHO or any website that uses the Anchor protocol

Prior, we were able to sign QR codes in the ESR format

But Anchor is an open source protocol to implement a secure channel between a website an an app.

https://github.com/greymass/anchor

Basically, this pull request enables correct handling of identity request with callbacks, and in other PRs later we can implement long-living sessions and etc

lib/screens/app/app.dart

gguijarro-c-chwy · 2021-02-18T22:22:52Z

Thank you for the video, but this PR has no issue attached to it and no explanations of whats the purpose of the PR.

n13

Some potentially unused files, some unused code, please fix

lib/providers/services/links_service.dart

lib/screens/app/app.dart

lib/screens/app/temp.json

lib/screens/app/app.dart

n13

move auth functions to other file - not sure if that means separating UX and logic as well - may have to at that point

lib/screens/app/app.dart

n13 · 2021-03-16T22:06:28Z

@7flash I tested this on the hypha website and it doesn't work for login.

I don't know why it doesn't work

The anchor login seems to be ok (get a success) but there's a backend protocol where it sets up a secure channel between the phone and the website and that doesn't seem to work

I would be OK with setting up a whole different website integration -

Example - we could just sign a policy transaction that connects a session ID with an account, proving login

Then sign all transactions with QR Code / link when on mobile

That would be easy to do for ut

Or we implement the anchor protocol but if we do that then we also need to handle the secure channel and requests coming from the website through anchor to our wallet.

I don't see any code that would do that in this PR - and I also don't know how to do that. Socket connection? IDK.

7flash · 2021-03-17T00:43:44Z

@7flash I tested this on the hypha website and it doesn't work for login.

I don't know why it doesn't work

The anchor login seems to be ok (get a success) but there's a backend protocol where it sets up a secure channel between the phone and the website and that doesn't seem to work

I would be OK with setting up a whole different website integration -

Example - we could just sign a policy transaction that connects a session ID with an account, proving login

Then sign all transactions with QR Code / link when on mobile

That would be easy to do for ut

Or we implement the anchor protocol but if we do that then we also need to handle the secure channel and requests coming from the website through anchor to our wallet.

I don't see any code that would do that in this PR - and I also don't know how to do that. Socket connection? IDK.

Yes, websocket connection via anchor-link protocol, I think it's already implemented on website, and I can implement long sessions on the app too

…gration

7flash · 2021-03-24T09:19:33Z

Tried with DHO - working too, can you please merge @n13

7flash · 2021-03-24T09:20:35Z

7flash · 2021-03-29T05:31:21Z

@gguij004 can you merge please

n13 · 2021-03-29T09:31:22Z

@gguij004 can you merge please

I think you mean Gery @gguijarro-c-chwy

Needs to approve ;)

gguijarro-c-chwy · 2021-03-29T14:10:43Z

I see merge conflicts and lint issues.

This so also targeting master and i think we should target the current release build 1.4.4 i think?

We can take care adding this feature to the master v2 build once it passes by design and product manager that creates a story to track the work and acceptance criteria.

@JGDoh @7flash @7flash

n13 · 2021-03-29T16:05:19Z

IDK it makes sense to target 2.0, I want to accelerate this Anchor login is a useful feature we definitely want it. @7flash can you fix the lint and merge issues? Acceptance criteris is a good point - I guess it needs to be able to log into the DHO and sign transactions there. This will reduce all our risks as we can remove our private keys from the anchor app...

…

On Mar 29, 2021, at 22:11, Gerardo Guijarro ***@***.***> wrote: I see merge conflicts and lint issues. This so also targeting master and i think we should target the current release build 1.4.4 i think? We can take care adding this feature to the master v2 build once it passes by design and product manager that creates a story to track the work and acceptance criteria. @JGDoh <https://github.com/JGDoh> @7flash <https://github.com/7flash> @7flash <https://github.com/7flash> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#517 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAP7BHJFSUVWTGQBDCGUD3TGCC7TANCNFSM4X24WBUQ>.

…gration

gguijarro-c-chwy · 2021-04-10T21:46:16Z

conflicts.
Please reopen when fixed

n13 · 2021-04-15T06:43:41Z

I see merge conflicts and lint issues.

This so also targeting master and i think we should target the current release build 1.4.4 i think?

We can take care adding this feature to the master v2 build once it passes by design and product manager that creates a story to track the work and acceptance criteria.

@JGDoh @7flash @7flash

We really need this - important to integrate with many of our projects, seeds swap etc.

I see no harm merging it and testing it.

Although lint needs to pass obviously @7flash

n13 · 2021-04-15T06:47:11Z

@gguijarro-c-chwy this one targets v2 / master, this is correct

n13 · 2021-04-15T06:51:20Z

Ticket is here #675

@gguijarro-c-chwy

gguijarro-c-chwy · 2021-04-15T12:15:06Z

Conflicts

gguijarro-c-chwy · 2021-04-15T12:18:18Z

lib/models/models.dart

@@ -30,7 +30,7 @@ class ProductModel extends HiveObject {
      currency: data.data()[PRODUCT_CURRENCY_KEY],
      position: data.data()[PRODUCT_POSITION_KEY] ?? 0,
    );


Any actual changes on this file or only formatting ?
It helps when the actual changes are pointed out. Saves the reviewers times.

gguijarro-c-chwy · 2021-04-15T12:19:45Z

lib/providers/services/esr_service.dart

@@ -0,0 +1,76 @@
+import 'dart:typed_data';
+
+import 'package:eosdart_ecc/eosdart_ecc.dart';


This code is pointing to master v2
All new code for v2 should be inside the V2 folder.

This is a service, should be inside the v2 services folder. remote

gguijarro-c-chwy · 2021-04-15T12:20:13Z

lib/providers/services/esr_service.dart

+import 'package:eosdart/src/serialize.dart' as ser;
+import 'package:dart_esr/dart_esr.dart';
+
+class IdentityResponse {


This is a model, should not live in the service, but in a model class

gguijarro-c-chwy · 2021-04-15T12:21:33Z

lib/providers/services/esr_service.dart

+import 'package:dart_esr/dart_esr.dart';
+
+class IdentityResponse {
+  final String callback;


callback?
a string?

When i think of a callback i think of a callback i think of a function.

Can we add comments to these params, explain what they represent.

Callback is a callback URL provided by the identity request

ah i see, perhaps name it
callbackUrl

gguijarro-c-chwy · 2021-04-15T12:21:59Z

lib/providers/services/esr_service.dart

+}
+
+class EsrService {
+  Future<IdentityResponse> getIdentityResponse({


Services return "Result" values

gguijarro-c-chwy · 2021-04-15T12:24:22Z

lib/screens/app/app.dart

 import 'package:seeds/widgets/pending_notification.dart';

+import 'process_dynamic_links.dart';


this import is not importing the package like the rest of imports?

gguijarro-c-chwy · 2021-04-15T12:28:13Z

lib/screens/app/process_dynamic_links.dart

+  }
+
+  void processTransactionRequest(SeedsESR request) async {
+    await request.resolve(


we no longer use SettingsNotifier to get the accountName
we use the storageService i think its the name. Its a singleton

gguijarro-c-chwy · 2021-04-15T12:30:56Z

lib/screens/app/process_dynamic_links.dart

+import 'package:url_launcher/url_launcher.dart' as UrlLauncher;
+import 'package:convert/convert.dart';
+
+class ProcessDynamicLinks extends StatefulWidget {


This entire class is a view,

There should be no network requests here
No Logic
No mappings
Etc

This class should have a bloc that handles all these things.

https://pub.dev/packages/flutter_bloc#:~:text=BlocProvider%20is%20a%20Flutter%20widget,multiple%20widgets%20within%20a%20subtree.

We have many examples how to integrate blocs into our views in V2. I am also here to help with any questions.

gguijarro-c-chwy · 2021-04-15T12:31:34Z

lib/screens/app/wallet/scan.dart

@@ -1,7 +1,9 @@
 import 'package:flutter/material.dart';
+import 'package:http/http.dart';


this class is already obsolete. we moved all the scan code over to v2

gguijarro-c-chwy · 2021-04-15T12:32:41Z

lib/screens/app/wallet/scan.dart

-    return esr.actions.first.account.isNotEmpty && esr.actions.first.name.isNotEmpty;
+  void processIdentityRequest(SeedsESR esr) async {
+    try {
+      var response = await EsrService().getIdentityResponse(


But fyi, no network calls are made from UI. Those are moved into services, blocs, useCases, mappers.

n13 · 2021-05-05T23:54:39Z

using anchor_v2 PR instead

anchor integration

7e5106f

gguijarro-c-chwy requested changes Feb 18, 2021

View reviewed changes

remove comments

e1243a6

n13 requested changes Feb 24, 2021

View reviewed changes

lib/providers/services/links_service.dart Outdated Show resolved Hide resolved

lib/screens/app/app.dart Outdated Show resolved Hide resolved

lib/screens/app/app.dart Outdated Show resolved Hide resolved

lib/screens/app/temp.json Outdated Show resolved Hide resolved

remove unused files

617dd53

gguijarro-c-chwy reviewed Feb 26, 2021

View reviewed changes

lib/screens/app/app.dart Outdated Show resolved Hide resolved

gguijarro-c-chwy reviewed Feb 26, 2021

View reviewed changes

lib/screens/app/app.dart Outdated Show resolved Hide resolved

format code

5a45a84

n13 requested changes Mar 2, 2021

View reviewed changes

lib/screens/app/app.dart Outdated Show resolved Hide resolved

lib/screens/app/app.dart Outdated Show resolved Hide resolved

7flash added 2 commits March 2, 2021 11:31

move process dynamic links to separate widget

7e4fd79

support qr identities

4c56667

Merge remote-tracking branch 'origin/master' into feature/anchor-inte…

54ad6e1

…gration

n13 requested review from gguijarro-c-chwy and n13 March 29, 2021 05:30

n13 approved these changes Mar 29, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into feature/anchor-inte…

ddf6260

…gration

gguijarro-c-chwy closed this Apr 10, 2021

n13 reopened this Apr 15, 2021

n13 mentioned this pull request Apr 15, 2021

Sign in and sign on websites with Anchor protocol #675

Closed

gguijarro-c-chwy requested changes Apr 15, 2021

View reviewed changes

handle seeds protocol links to open web sites inside of wallet wrapper

1e5b9aa

n13 closed this May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

anchor integration #517

anchor integration #517

7flash commented Feb 18, 2021 •

edited by n13

gguijarro-c-chwy commented Feb 18, 2021

n13 left a comment

n13 left a comment

n13 commented Mar 16, 2021

7flash commented Mar 17, 2021

7flash commented Mar 24, 2021

7flash commented Mar 24, 2021

7flash commented Mar 29, 2021

n13 commented Mar 29, 2021

gguijarro-c-chwy commented Mar 29, 2021

n13 commented Mar 29, 2021 via email

gguijarro-c-chwy commented Apr 10, 2021

n13 commented Apr 15, 2021

n13 commented Apr 15, 2021

n13 commented Apr 15, 2021

gguijarro-c-chwy commented Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

n13 Apr 19, 2021

gguijarro-c-chwy Apr 19, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

gguijarro-c-chwy Apr 15, 2021

n13 commented May 5, 2021

		@@ -0,0 +1,76 @@
		import 'dart:typed_data';

		import 'package:eosdart_ecc/eosdart_ecc.dart';

		import 'package:seeds/widgets/pending_notification.dart';

		import 'process_dynamic_links.dart';

		@@ -1,7 +1,9 @@
		import 'package:flutter/material.dart';
		import 'package:http/http.dart';

anchor integration #517

anchor integration #517

Conversation

7flash commented Feb 18, 2021 • edited by n13

gguijarro-c-chwy commented Feb 18, 2021

n13 left a comment

Choose a reason for hiding this comment

n13 left a comment

Choose a reason for hiding this comment

n13 commented Mar 16, 2021

7flash commented Mar 17, 2021

7flash commented Mar 24, 2021

7flash commented Mar 24, 2021

7flash commented Mar 29, 2021

n13 commented Mar 29, 2021

gguijarro-c-chwy commented Mar 29, 2021

n13 commented Mar 29, 2021 via email

gguijarro-c-chwy commented Apr 10, 2021

n13 commented Apr 15, 2021

n13 commented Apr 15, 2021

n13 commented Apr 15, 2021

gguijarro-c-chwy commented Apr 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

n13 commented May 5, 2021

7flash commented Feb 18, 2021 •

edited by n13