Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with aah framework is broken #22

Closed
jeevatkm opened this issue Apr 24, 2018 · 5 comments
Closed

Integration with aah framework is broken #22

jeevatkm opened this issue Apr 24, 2018 · 5 comments

Comments

@jeevatkm
Copy link

jeevatkm commented Apr 24, 2018

Hello @Joker - With v0.10 release I have integrated the Jade library with aah framework go-aah/aah#171.

I was able to achieve aah views directory structure with your previous version along with own include template function. Please you have a look on library located at https://github.com/aah-cb/ve-pug

aah views directory structure:

├── common
│   ├── error_footer.pug
│   ├── error_header.pug
│   ├── footer_scripts.pug
│   └── head_tags.pug
├── errors
│   ├── 404.pug
│   └── 500.pug
├── layouts
│   └── master.pug
└── pages
    └── app
        └── index.pug

pages directory would contain subdirectories (including nested directories) for each controller and its namespace. And each action would have respective template file in the directory.

More about aah views: https://docs.aahframework.org/views.html


Looking forward to your support to make the integration work again, thanks.

@omeid
Copy link
Contributor

omeid commented Apr 24, 2018

This issue has nothing to do with Jade. Please stop spamming.

@jeevatkm
Copy link
Author

@omeid My goal is to make the integration work and seeking for support. NOT SPAMMING. NOT BLAMING, I hope you have read above detailed description. Do you think asking help is spamming?

With latest Jade improvements, I'm missing following elements -

  • Template delimiter option (not sure how much is relevant with latest changes, may be taken care automatically, I don't know)
  • include function is now handled within library so it will look for relative path for referred file unlike previous version I was managing source location externally.

Right now I'm working on this, not just create an issue and toss it aside. I request you please not to make a quick judgement.

@jeevatkm
Copy link
Author

@omeid BTW I have informed here before I began my work please refer here #18 Keeping informed is important. Thank you.

@omeid
Copy link
Contributor

omeid commented Apr 24, 2018

If you require any specific functionality please open an issue outlining your requirement, better yet, create a pull request for that. This issue as standards is nothing far from spam.

People watch projects because they have an interest in the project, spamming those people with a constant stream of notifications about peripheral concerns is annoying.

@jeevatkm
Copy link
Author

People watch projects because they have an interest in the project

I completely agree.


Let me give a problem insights.

So above difference affected the downstream library.

Given situation, Would you just jump on creating PR or Requesting feature or Get an thought process of author via available medium before reaching a conclusion.

@Joker Joker closed this as completed Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants