Precompile go file, write function created wrong #35

miachel-lv · 2020-05-02T11:47:34Z

This is model file:

This is my jade file:

after do precompiled to go file:

I don't understand why in function 'Simple' loop, StroyId UserId are call 'WriteAll' function write to buffer, and why not call 'WriteUint' function write to buffer.

The jade command I executed: ./jade index.jade

my project tree:

Hope you can reply me, thanks!

Joker · 2020-05-02T21:57:53Z

WriteAll() function is used for all non-primitive types
because at the stage of the jade file translation it's impossible to determine what type the line li= story.UserId contains.
The translator uses only jade files to get information about types.

Qubitium · 2020-05-05T00:48:57Z

@Joker I am a co-worker of @miachel-lv

We are evaluating Jade/Golang for a large project and thus far we a perplexed at the randomless of how some templates are using optimized WriteXXX methods versus the default but very slow WriteAll.

So our question:

When is Jade parse able to detect actual go struct types? We have templates that imports go struct types that is able to generate optimized WriteUint() but we don't see much consistency as when it works and when it doesn't.
The GoAST files are the code that does the go import and field type detection. We suspect this is a bug somewhere that allows Jade parsing to detect types on some imported structs and fail on others, based on error logging.
We need more in depth assistance in how Jade/Golang AST/import parse deal with native golang int/uint/string types.
Without Native type WriteXXX support, Jade is at significant performance disadvantage compared to Hero which use expliciti type declaration/hinting in the template language itself. We don't see explicit type declaration possible with JadeLang or are we wrong here?

Thanks for all the help. We are willing to assist in helping make this pkg better since we really like the Jade template language.

Qubitium · 2020-05-05T01:04:49Z

@Joker.

Look at the https://github.com/SlinSo/goTemplateBenchmark/blob/master/jade/simple.jade

:go:func Simple( u *model.User)

:go:import "github.com/SlinSo/goTemplateBenchmark/model"

html
    body
        h1= u.FirstName
        p Here's a list of your favorite colors:
        ul
            each colorName in u.FavoriteColors
                li= colorName

and generated https://github.com/SlinSo/goTemplateBenchmark/blob/master/jade/simple.jade.go

// Code generated by "jade.go"; DO NOT EDIT.

package jade

import (
	"github.com/SlinSo/goTemplateBenchmark/model"
	pool "github.com/valyala/bytebufferpool"
)

const (
	simple__0 = `<html><body><h1>`
	simple__1 = `</h1><p>Here's a list of your favorite colors:</p><ul>`
	simple__2 = `</ul></body></html>`
	simple__3 = `<li>`
	simple__4 = `</li>`
)

func Simple(u *model.User, buffer *pool.ByteBuffer) {

	buffer.WriteString(simple__0)
	WriteEscString(u.FirstName, buffer)
	buffer.WriteString(simple__1)

	for _, colorName := range u.FavoriteColors {
		buffer.WriteString(simple__3)
		WriteEscString(colorName, buffer)
		buffer.WriteString(simple__4)
	}
	buffer.WriteString(simple__2)

}

Model:

package model

type User struct {
	FirstName      string
	Email string
	FavoriteColors []string
	RawContent string
	EscapedContent string
}

type Navigation struct {
	Item string
	Link string
}

It is able to import a go struct with a simple String type field and Jade parser was able to detect the native String type and use WriteEscString() instead of WriteAll(str, true).

I don't understand how that example is different in the one provided by @miachel-lv which failed struct native type detection.

Joker · 2020-05-06T14:44:43Z

Thanks a lot, your question helped me to find a bug which occurred due to new Go version.

Qubitium · 2020-05-06T23:54:52Z

@Joker Awesome.

Joker closed this as completed in ee26e3c May 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Precompile go file, write function created wrong #35

Precompile go file, write function created wrong #35

miachel-lv commented May 2, 2020

Joker commented May 2, 2020 •

edited

Loading

Qubitium commented May 5, 2020

Qubitium commented May 5, 2020 •

edited

Loading

Joker commented May 6, 2020

Qubitium commented May 6, 2020

Precompile go file, write function created wrong #35

Precompile go file, write function created wrong #35

Comments

miachel-lv commented May 2, 2020

Joker commented May 2, 2020 • edited Loading

Qubitium commented May 5, 2020

Qubitium commented May 5, 2020 • edited Loading

Joker commented May 6, 2020

Qubitium commented May 6, 2020

Joker commented May 2, 2020 •

edited

Loading

Qubitium commented May 5, 2020 •

edited

Loading