Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project setup with webpack #1

Merged
merged 13 commits into from Oct 12, 2022
Merged

Add project setup with webpack #1

merged 13 commits into from Oct 12, 2022

Conversation

JonahKayizzi
Copy link
Owner

This pull request comprises the following changes;

  • Setup the project repo with Gitflow
  • Set up the JavaScript project for the Leaderboard list app, using webpack
  • Used ES6 modules with import and export.
  • Developed the first working version of the app

Copy link

@tresorsawasawa tresorsawasawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVE ✔️ ✔️ 🍾

Hi @JonahKayizzi
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 👏 👏 💯

nodding-yes

To highlight 🍾

  • All linters are passing ✔️
  • Good commit history ✔️
  • Good PR description ✔️
  • Your README file is professional ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @tresorsawasawa when you comment so I can receive the notification or use slack with the same name.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@JonahKayizzi JonahKayizzi merged commit d9a7901 into dev Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants