Extend rule to look into Template Literal and BinaryExpressions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
requested changes
Jul 31, 2023
| @@ -85,8 +85,25 @@ const noLookaheadLookbehindRegexp: Rule.RuleModule = { | |||
| if (!unsupportedTargets.length && hasConfig) return {}; | |||
|
|
|||
| return { | |||
| TemplateLiteral(node: ESTree.TemplateLiteral & Rule.NodeParentExtension): void { | |||
| for (let quasi of node.quasis) { | |||
There was a problem hiding this comment.
I think this would end up reporting the problem on any string template literal (regardless if it is used inside a regexp or not). We should first check if the template literal is inside a regexp constructor before we iterate over all the nodes
|
@RatoX I'm sorry for the delayed review, I missed this in the flood of GH notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This Pull Request is improving the lint rule to check more edge cases, like:
However, it still doesn't cover this kind of scenario:
That would require a little bit of more code.