Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS incompatibility #81

Open
rasteiner opened this issue Mar 7, 2016 · 0 comments
Open

iOS incompatibility #81

rasteiner opened this issue Mar 7, 2016 · 0 comments
Assignees

Comments

@rasteiner
Copy link

When visiting a panel page having this plugin, with an iPhone (tested on iOS 7 and 9), the panel page keeps reloading (My best guess is that it's Kirby that reloads when detecting a JS error).

I've isolated the problem to this line: https://github.com/JonasDoebertin/kirby-visual-markdown/blob/master/assets/js/visualmarkdownfield.js#L76

The console says something on the line of

'undefined' is not an object (evaluating screenfull.raw.fullscreenchange)

infact, replacing that line with

if(screenfull.raw && screenfull.raw.fullscreenchange) {
        $(document).bind(screenfull.raw.fullscreenchange, self.changeFullscreenModeHandler);
}

kind of solves that problem (the page no longer reloads constantly).
Of course the fullscreen button doesn't work anymore then, but at least the page becomes usable and, given that error message, I'm not sure it would work anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants