Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong index of buffers in analysis.py #2

Closed
LuckMonkeys opened this issue Sep 1, 2022 · 1 comment
Closed

Wrong index of buffers in analysis.py #2

LuckMonkeys opened this issue Sep 1, 2022 · 1 comment

Comments

@LuckMonkeys
Copy link

When set user.provide_buffers=True, the user adds model buffers in true_user_data["buffers"]->[Tensors].
However, in analysis.py, it iterates through true_user_data["buffers"][idx]->Tensor. The [idx] does not needed and should be removed.

for buffer, user_state in zip(model.buffers(), true_user_data["buffers"][idx]):

for buffer, user_state in zip(model.buffers(), true_user_data["buffers"]):

@JonasGeiping
Copy link
Owner

Thanks for the report!

This will be fixed in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants