Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected change to server model in benchmark #3

Closed
LuckMonkeys opened this issue Sep 15, 2022 · 1 comment
Closed

Unexpected change to server model in benchmark #3

LuckMonkeys opened this issue Sep 15, 2022 · 1 comment

Comments

@LuckMonkeys
Copy link

Hi

In breaching.analysis.report() function, it directly uses the server.model to load the parameters and buffers. However, this may cause wrong modification to server.model and influences the next run in benchmark. It may be possible to resolve the problem by adding model=copy.deepcopy(model) before model.to(**setup)

    model = copy.deepcopy(model)
    model.to(**setup) 
@JonasGeiping
Copy link
Owner

I didn't have this issue so far, but a fix is now included, just in case: 4061351.

Thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants