Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind ChatPage for attachments in message #149

Closed
2 of 5 tasks
JayKim94 opened this issue Jun 11, 2021 · 13 comments · Fixed by #201
Closed
2 of 5 tasks

Bind ChatPage for attachments in message #149

JayKim94 opened this issue Jun 11, 2021 · 13 comments · Fixed by #201
Assignees
Labels
effort: medium Shouldn't take too long... feature New feature frontend priority: high Defining feature or very useful... status: in development

Comments

@JayKim94
Copy link
Collaborator

JayKim94 commented Jun 11, 2021

UWP.Services

  • ChatHubService should provide method to upload SelectedFiles in ChatPage
  • ChatHubService should provide method to download files from AttachmentsBlobName in Message model

UWP.ViewModels

  • ChatViewModel should provide command for the view to invoke upload in ChatHubService with SelectedFiles in the view model
  • ChatViewModel should provide command for the view to invoke download in ChatHubService with AttachmentBlobNames of a message

UWP.Views

  • On ChatPage users should be able to see attachment files in a message and invoke the command in ChatViewModel on click
@JayKim94 JayKim94 added feature New feature frontend priority: high Defining feature or very useful... effort: medium Shouldn't take too long... labels Jun 11, 2021
@JayKim94 JayKim94 added this to the Sprint 2 milestone Jun 11, 2021
@JayKim94 JayKim94 self-assigned this Jun 11, 2021
@JonasMuehlmann
Copy link
Owner

JonasMuehlmann commented Jun 11, 2021

Check with @RayanMirzaie and @robbelDev before starting work on this.
AFAIK the first point is at least partially implemented and the second and third might be too.
Maybe have a look at their branches.

@JonasMuehlmann
Copy link
Owner

Also, please add a status label.

@JayKim94
Copy link
Collaborator Author

JayKim94 commented Jun 12, 2021

Check with @RayanMirzaie and @robbelDev before starting work on this.
AFAIK the first point is at least partially implemented and the second and third might be too.
Maybe have a look at their branches.

image
The interface is there, but not at all implemented

image
And this partially implemented method SelectedFile_Click in ChatPage should also be refactored to be inside ChatPageViewModel and should be forwarded from there to be handled by ChatHubService, not on the view element itself.

I have already checked branch Ryan and Robin for changes, but I believe there will be no further updates on this.
Same goes for the last two points, there is no issue for them to be worked on / being worked on. Therefore I will take over.

@robbelDev
Copy link
Collaborator

robbelDev commented Jun 12, 2021

A Implementation of the SelectedFile_Click to the ChatPageViewModel and the Binding to the Listview is already done in Pull-request: #147 @JayKim94

@JayKim94
Copy link
Collaborator Author

JayKim94 commented Jun 12, 2021

A Implementation of the SelectedFile_Click to the ChatPageViewModel and the Binding to the Listview is already done in Pull-request: #147 @JayKim94

Oh okay nice! Then I remove the first requirement User should be able to attach files to the message and upload the files to the blob storage.

What about the other requirements? for example Users should be able to download the attachment files from the blob storage on click? Do Messages show AttachmentBlobNames on ChatPage?

@JayKim94
Copy link
Collaborator Author

JayKim94 commented Jun 12, 2021

Moved ChatPage related issues to a separate issue #150

@JayKim94
Copy link
Collaborator Author

Rewrote the requirements to clear up the intentions

@JayKim94
Copy link
Collaborator Author

JayKim94 commented Jul 7, 2021

The issue is still in development (temporarily suspended) #201

@robbelDev
Copy link
Collaborator

Can some body explain me were the problem is (were in the code)? There is also gone some code while mergin and we need some design to display the attachments when opened and in the message? @JayKim94

@JonasMuehlmann
Copy link
Owner

@robbelDev The responsible file is the FileSharingService.cs.
The problem, as far as I understand, is that conventional ways of doing file operations(with System.IO) does not work in UWP apps because they are sandboxed. Instead, one has to use the Windows.Storage namespace. Another problem is that UWP apps, by default, only have access to a few specific locations in the file system, and we need to set permissions to access the remaining locations.

@robbelDev
Copy link
Collaborator

@JonasMuehlmann can you look up whether I uploaded some files? :)

@robbelDev robbelDev self-assigned this Aug 15, 2021
@JonasMuehlmann
Copy link
Owner

@robbelDev Did you upload the folder 2021?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Shouldn't take too long... feature New feature frontend priority: high Defining feature or very useful... status: in development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants