Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement image sharing #99

Closed
7 tasks done
JonasMuehlmann opened this issue Jun 3, 2021 · 3 comments · Fixed by #105
Closed
7 tasks done

Implement image sharing #99

JonasMuehlmann opened this issue Jun 3, 2021 · 3 comments · Fixed by #105
Assignees
@JonasMuehlmann
Labels
backend effort: medium Shouldn't take too long... feature New feature priority: high Defining feature or very useful... status: in development
Milestone
Sprint 2

Comments

@JonasMuehlmann
Copy link
Owner

JonasMuehlmann commented Jun 3, 2021 •
edited

  • Upload
  • Download
  • Download in custom dir
  • Remote storage
  • Local cache
  • Sending images(with messages?)
  • Tests
@JonasMuehlmann JonasMuehlmann added the feature New feature label Jun 3, 2021
@JonasMuehlmann JonasMuehlmann self-assigned this Jun 3, 2021
@JonasMuehlmann
Copy link
Owner Author

Investigating the usage of azure blobs...

@JonasMuehlmann JonasMuehlmann changed the title Implement image sharing Backend: Implement image sharing Jun 3, 2021
@JonasMuehlmann JonasMuehlmann added this to the Sprint 2 milestone Jun 3, 2021
@JonasMuehlmann JonasMuehlmann mentioned this issue Jun 3, 2021
Closed
3 tasks
@JonasMuehlmann JonasMuehlmann changed the title Backend: Implement image sharing Implement image sharing Jun 3, 2021
@JonasMuehlmann JonasMuehlmann added backend effort: medium Shouldn't take too long... priority: high Defining feature or very useful... status: in development labels Jun 3, 2021
@JonasMuehlmann
Copy link
Owner Author

Working on branch image_sharing

@JonasMuehlmann JonasMuehlmann added discussion Requires opinions of team members and removed discussion Requires opinions of team members labels Jun 3, 2021
@JonasMuehlmann
Copy link
Owner Author

JonasMuehlmann commented Jun 3, 2021 •
edited

Now that uploading files is possible on the service level, we need to think about the database model.
AFAIK, our data model has no reference to uploaded files, so my idea is to add a column attachmentsId which encodes the blob names of attached files.
For that column, I propose the format of simply separating the blob names by a comma.
On the client side model (Message class), it could map to List<string>.

@JayKim94 Thoughts?

Edit: Alternatively, we could think about only uploading (compressed) archives in which case we would have only one blob name and could offer an overloaded upload function taking a list of file paths or variadic parameters(do these exist in c#?).

@JonasMuehlmann JonasMuehlmann linked a pull request Jun 4, 2021 that will close this issue
Implementation of File sharing #105
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasMuehlmann JonasMuehlmann

Labels
backend effort: medium Shouldn't take too long... feature New feature priority: high Defining feature or very useful... status: in development
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging a pull request may close this issue.

Implementation of File sharing JonasMuehlmann/BIB_VPR
1 participant
@JonasMuehlmann