-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest.json file listens for compilation issues #261
Comments
Thank you for your contribution. We will check and reply to you as soon as possible. |
@wangxinyugithub We're not listening for files outside of src, but i think also about listening for manifest or other core files. Are you want to open PR with that change? But it's possibility @Jonghakseo will want to do it, when he will working on #184 |
Now i have a think. This template is created for solved issue with working on yours plugins, not the core code, manifest is outside of src. We must think about it, maybe it's good idee. Let's wait whats @Jonghakseo write :) |
I'll delegate the change detection for local files to the filesystem and apply the changes detected by the plugin to the completion of the build. While I'm at it, I'll also look at this issue. |
I was hoping to be able to handle the issue content while doing the above, but it's more complicated than I thought, so I'll cover that separately. I need to create a new manifest when I change the manifest, which is inconvenient because I have to reimport the changed manifest.ts file, but I think I can do it, just be a bit patient. |
As you write, it's not working now, it detect changes in manifest, but after reload the content inside output manifest.json is old |
This is a complicated issue. I used dynamic import to re-import the manifest at the end of the build, but the module system recognized it as a cached module already, so the changes to the contents are not reflected. I should probably replace the manifest file with js (keeping the type as JSDoc) and use require, but that doesn't seem easy since vite already works as an esm. :( |
@all-contributors please add @wangxinyugithub for bug |
I've put up a pull request to add @wangxinyugithub! 🎉 |
The manifest.ts file has added listening, but the contents modified after starting local development are not updated in the compiled dist file
It is hoped that the contents of the manifest.ts file can be modified during the development process to monitor the simultaneous update of the manifest.json file in the dist file after recompilation
The text was updated successfully, but these errors were encountered: