Only submit/handle non-empty ISRCs (cdrdao)

[Freso]

If multiple tracks on a CD have an empty ISRC, isrcsubmit will register them as having the same ISRC (which, I guess, they technically do), and will also try to submit these empty ISRCs to MusicBrainz.

See this log: https://pastee.org/6g6wt

[JonnyJD]

ISRCs in CD-TEXT can be empty.. interesting.

So I have to check at least for empty isrcs.
Not really sure if the server would accept empty ISRCs, but this is at least a major usability problem.

Thanks for reporting this.

[JonnyJD]

For later reference (pastee is temporary), part of the TOC:

CATALOG "5099748936424"
CD_TEXT {
  LANGUAGE_MAP {
    0: 9
  }
  LANGUAGE 0 {
    TITLE "THE SOUL TRAIN CHRISTMAS STARFEST SOUNDTRACK ALBUM"
    PERFORMER "Various"
    DISC_ID "EK68679"
    UPC_EAN ""
    SIZE_INFO { 1,  1, 16,  3, 44, 21,  0,  0,  0,  0,  1,  0,
                0,  0,  0,  0,  0,  0,  7,  3, 75,  0,  0,  0,
                0,  0,  0,  0,  9,  0,  0,  0,  0,  0,  0,  0}
  }
}

// Track 1
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
CD_TEXT {
  LANGUAGE 0 {
    TITLE "Let It Snow"
    PERFORMER "Boyz II Men"
    DISC_ID ""
    ISRC ""
  }
}
FILE "data.wav" 0 04:12:00


// Track 2
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "USSM19501455"
CD_TEXT {
  LANGUAGE 0 {
    TITLE "Every Year, Every Christmas"
    PERFORMER "Luther Vandross"
    DISC_ID ""
    ISRC "US-SM1-95-01455"
  }
}
FILE "data.wav" 04:12:00 05:06:10


// Track 3
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "USSM19702176"
CD_TEXT {
  LANGUAGE 0 {
    TITLE "God Bless The Dreamer"
    PERFORMER "Simone Hines"
    DISC_ID ""
    ISRC "US-SM1-97-02176"
  }
}
FILE "data.wav" 09:18:10 04:57:60


// Track 4
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
CD_TEXT {
  LANGUAGE 0 {
    TITLE "O Come All Ye Faithful"
    PERFORMER "Az Yet"
    DISC_ID ""
    ISRC ""
  }
}
FILE "data.wav" 14:15:70 04:12:57


// Track 5
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
CD_TEXT {
  LANGUAGE 0 {
    TITLE "Silent Nite (Happy Holiday Mix)"
    PERFORMER "En Vogue"
    ISRC ""
  }
}
FILE "data.wav" 18:28:52 05:23:73


// Track 6
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "USIR29600338"
CD_TEXT {
  LANGUAGE 0 {
    TITLE "Special Gift"
    PERFORMER "The Isley Brothers Featuring Ronald Isley"
    ISRC "US-IR2-96-00338"
  }
}
FILE "data.wav" 23:52:50 04:00:72