Suppress device name output from libdiscid in Windows

[JonnyJD]

The Windows code for libdiscid has:

 strcpy(filename, "\\\\.\\");
        len = strlen(device);
        if (colon = strchr(device, ':')) {
                len = colon - device + 1;
        }
        strncat(filename, device, len > 120 ? 120 : len);
        printf("%s\n", device);
        printf("%s\n", filename);

Which on our end leads to this output:

D:
\\.\D:

after using mediatools.

There is no output like this on other platforms.

Since we don't print these lines, we can't just "not print" these. We can try to disable stdout just before we use libdiscid: http://stackoverflow.com/questions/4178614/suppressing-output-of-module-calling-outside-library

[jesus2099]

Wow, so cool !

[Freso]

This should probably be fixed upstream though, instead of making a (relatively) lengthy work-around.

I do like the and not debug though. 👍

[JonnyJD]

I created an upstream report:
http://tickets.musicbrainz.org/browse/LIB-20

I doubt this will be fixed soon, though.

[JonnyJD]

Fixed upstream with metabrainz/libdiscid@15b4ba7

Actually this was already fixed 5 years ago, but this was only in the isrc branch.
The fix is now life with libdiscid 0.3.0

I can probably remove the hack when we have a working windows build of libdiscid 0.3.0.
http://ftp.musicbrainz.org/pub/musicbrainz/libdiscid/libdiscid-0.3.0-win32bin.zip needs MSVCR100 and I don't want to include that in my windows package.

[jesus2099]

You’re right, the less files, the better. :)

[JonnyJD]

Could you try http://isrcsubmit.jonnyjd.net/downloads/libdiscid-0.3.0-win32.zip? That shouldn't depend on anything that's not part of the system.

If that works, I can link that everywhere and remove that weird fix again.

[jesus2099]

It worked with mediatools backend. :)
I will test your new release then, because I have a global name 'saneWhich' is not defined error when I try to use cdrdao. I think my version might be a mix of various file tries and be happy to install a new clean version. :)

[JonnyJD]

0.5.2 is this "new clean version".

0.6 is still not done.
Potentially 0.6 will be named 1.0 and I will work on 2.0 aftewards (with NGS).