Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submission url for NGS #32

Merged
merged 2 commits into from Jun 25, 2013
Merged

update submission url for NGS #32

merged 2 commits into from Jun 25, 2013

Conversation

JonnyJD
Copy link
Owner

@JonnyJD JonnyJD commented Jun 13, 2013

The url given by libdiscid also works, but is redirected.
This saves the redirection.

The url given by libdiscid also works, but is redirected.
This saves the redirection.
@ghost ghost assigned JonnyJD Jun 13, 2013
@phw
Copy link

phw commented Jun 14, 2013

Any objection in also changing it in libdiscid directly?

Nothing wrong with having this rewriting here, though, as python-discid is supposed to support older releases of libdiscid as well. But I personally would prefer this change in libdiscid and keep the code clean in at least my client libraries ;)

@JonnyJD
Copy link
Owner Author

JonnyJD commented Jun 14, 2013

It's not such a big performance deal. The redirects are additional requests, but nothing big or with DB access, so basically very cheap.

You never know what tools somehow depend on libdiscid having a certain string in the submission_url.
That is basically the reason for not changing it in libdiscid.
A asked about it in #musicbrainz-devel:
http://chatlogs.musicbrainz.org/musicbrainz-devel/2013/2013-06/2013-06-13.html#T18-30-40-213566
ian said it was "totally insignificant".
So nothing I would change a long-running library for.
This is different for python-discid, since it is a new library, although based on libdiscid output.

Tell me when you get or see a different indication from the server guys.
I also haven't seen objection either.

JonnyJD added a commit that referenced this pull request Jun 25, 2013
see pull-request #32
@JonnyJD JonnyJD merged commit c3d6cad into master Jun 25, 2013
@JonnyJD JonnyJD deleted the update_url branch June 25, 2013 02:09
@JonnyJD
Copy link
Owner Author

JonnyJD commented Jul 25, 2013

Not sure why this isn't linked automatically, but this is possibly also changed for libdiscid directly in metabrainz/libdiscid#33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants