Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rewrite the package, and make it use decancer v1.5.2 #2

Merged
merged 4 commits into from Dec 26, 2022
Merged

*: rewrite the package, and make it use decancer v1.5.2 #2

merged 4 commits into from Dec 26, 2022

Conversation

null8626
Copy link
Contributor

THANK YOU ❤️❤️❤️ for supporting decancer, even labeling it as a "Sweet lib that does all the work for us"!!! ❤️❤️❤️

i've listed your package as the unofficial Python package for decancer in the main project's README since version 1.5.1. THANK YOU for supporting this project!

this pull request intends to:

  • rewrite most of the package to use the currently latest decancer release (this WILL be a major breaking update, note that!)
  • add rustfmt.toml for styling purposes
  • remove rust tests, since those are already covered in the main project, so a cargo test is not required

if you have any issues with this pull request, feel free to let me know!

@null8626
Copy link
Contributor Author

this pull request should cover the changes in #1, but in a more proper way by using Python classes!

@Jonxslays
Copy link
Owner

I'm merging this as is, I'll make some additional necessary changes on my end before releasing.

Thanks a lot for the contribution, and the decancer crate itself - super useful :).

@Jonxslays Jonxslays merged commit 0b75fbd into Jonxslays:master Dec 26, 2022
@null8626
Copy link
Contributor Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants