Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.18] .form-horizontal .controls - to delete #388

Open
joomleb opened this issue Dec 16, 2023 · 3 comments
Open

[2.0.18] .form-horizontal .controls - to delete #388

joomleb opened this issue Dec 16, 2023 · 3 comments

Comments

@joomleb
Copy link

joomleb commented Dec 16, 2023

Hi guys,
…/templates/shaper_helixultimate/css/template.css
.form-horizontal .controls {
margin-left: 220px;}

From my point of view it can and it should be deleted as inherit deprecated code:

  • It is only wasting precious space
  • It is unusable on mobile (smeller screens)
  • It is conflicting with some 3rd party components that are using specific settings

Do you agree ?

@joomleb joomleb changed the title [2.0.18] .form-horizontal .controls { margin-left: 220px;} [2.0.18] .form-horizontal .controls - to delete Dec 16, 2023
@joomleb
Copy link
Author

joomleb commented Feb 9, 2024

@mi-prakash
Do you agree?

@mi-prakash
Copy link
Collaborator

@joomleb
i'll check on this
thanks for the feedback

@joomleb
Copy link
Author

joomleb commented May 11, 2024

Hi @mi-prakash
as far as I see the code is still present in the last 2.1.0 release.
Did you checked it and you decided to don't remove it, OR simply you haven't checked it yet ?!?

PS thank you in advance for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants