Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier method for scripture Input #147

Closed
genu opened this issue Apr 9, 2013 · 6 comments
Closed

Easier method for scripture Input #147

genu opened this issue Apr 9, 2013 · 6 comments

Comments

@genu
Copy link
Member

genu commented Apr 9, 2013

For the longest time, the scripture has been inputed as: book, chapter_begin, verse_begin, verse_end, chapter_end, book2, chapter_begin2 etc.

A good improvement to this, is to allow the user to enter scripture references directly like so:

John 3:16, Romans 1:16

I'm thinking this could be implemented as a single text field with autocomplete, so that only correct scripture references are acceptable.

A utility class will need to be created to validate a given input to test whether its a valid scripture or not. (i.e. John 3:16 would be valid, while john 0:16 would be invalid). The user is alerted whether a references they entered is valid or not as they're entering it. Multiple references are simply separated by a comma.

Taking this approach, will allow us to truncate more than 10 columns in the message database.

Related Tasks

  • It will require a data migration from the old format.
@tomfuller2
Copy link
Member

Great idea, Eugen. I originally modeled the Scripture entry on SermonCentral.com.

@bcordis
Copy link
Member

bcordis commented Apr 9, 2013

We still cold us the tables as is but just do some JS to fill in the right
fields. We still need the each filed I think.

On Tue, Apr 9, 2013 at 9:52 AM, tomfuller2 notifications@github.com wrote:

Great idea, Eugen. I originally modeled the Scripture entry on
SermonCentral.com.


Reply to this email directly or view it on GitHubhttps://github.com//issues/147#issuecomment-16117229
.

Thanks,
Brent Cordis
2406 Hermitage Park Dr.
Hermitage, TN 37076
615.429.6426

@genu
Copy link
Member Author

genu commented Apr 9, 2013

@bcordis
The challenge would probably be to update all the references to the message scripture references, and filters.

The filters by default, I believe, work only on column values, so for filtering by a specific book under this method is a little bit more complex.

If we implement this in a utility class (or library?), then the burden would be on this utility class of providing proper methods for handling filtering, localization, and other required functionality.

@bcordis
Copy link
Member

bcordis commented Apr 9, 2013

@genu
Like in contacts there is the ability to explode out the entry into a object db and then same each one into there appropriate table columns?

@genu
Copy link
Member Author

genu commented Apr 9, 2013

I didn't look how the contacts component works.

We could, as a first step in this direction, take that route and just map a string of scripture references to those table columns. However, we will still be limited by only 2 scripture references per message. correct?

@bcordis
Copy link
Member

bcordis commented Apr 9, 2013

unless we redo the db and do it in a JSON string in one column.

On Tue, Apr 9, 2013 at 11:06 AM, Eugen Istoc notifications@github.comwrote:

I didn't look how the contacts component works.

We could, as a first step in this direction, take that route and just map
a string of scripture references to those table columns. However, we will
still be limited by only 2 scripture references per message. correct?


Reply to this email directly or view it on GitHubhttps://github.com//issues/147#issuecomment-16122506
.

Thanks,
Brent Cordis
2406 Hermitage Park Dr.
Hermitage, TN 37076
615.429.6426

@bcordis bcordis modified the milestones: 9.1.0, 9.1.1 Nov 5, 2017
@bcordis bcordis removed this from the 9.1.1 milestone Mar 25, 2018
@bcordis bcordis closed this as completed Mar 26, 2021
@Joomla-Bible-Study Joomla-Bible-Study locked and limited conversation to collaborators Mar 26, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

3 participants