Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi to wav attempts to unload incorrect SoundBank #3

Open
k4pran opened this issue Dec 27, 2017 · 0 comments
Open

Midi to wav attempts to unload incorrect SoundBank #3

k4pran opened this issue Dec 27, 2017 · 0 comments

Comments

@k4pran
Copy link

k4pran commented Dec 27, 2017

this.synth.unloadAllInstruments(soundbank);

In the class MidiToWavRenderer when using custom SoundBank to create the wav file their is an attempt to unload the default SoundBank:

this.synth.unloadAllInstruments(soundbank);

soundbank is the custom SoundBank and so will not unload anything. It also means the next attempt to load the custom SoundBank silently fails:

...
this.synth.unloadAllInstruments(soundbank);
final Instrument[] instruments = soundbank.getInstruments();
for (final Instrument instrument : instruments) {
	synth.loadInstrument(instrument);
}
createWavFile(midiFile, outputFile);
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant