Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of the library. #5

Closed
bn-l opened this issue Sep 15, 2017 · 10 comments
Closed

Change name of the library. #5

bn-l opened this issue Sep 15, 2017 · 10 comments

Comments

@bn-l
Copy link

bn-l commented Sep 15, 2017

Consider changing name. Thought this was something for cond inheritance.

@jorgebucaran
Copy link
Owner

@bn-l If you are going to go out of your way to open an issue, you may consider suggesting an alternative name along with your ticket? 🤔

@bn-l
Copy link
Author

bn-l commented Sep 15, 2017

Very good point.

CssStyleConcat

@bn-l
Copy link
Author

bn-l commented Sep 15, 2017

StyleWrap
CSSWrapUp
CondStyleWrap

I'm spent. I need a cigarette.

@jorgebucaran
Copy link
Owner

jorgebucaran commented Sep 15, 2017

Please remember that this library is pretty much only intended to join class names. For that reason using the word Style doesn't really work.

Also spent some time thinking about the name and discussed it with several peers before I published classwrap:

  • classzip or zipclass
  • classjoin or joinclass
  • classconcat or concatclass
  • classnames3

In the end I chose classwrap because it sounded goofy and someone said reminded them of a sandwich.

@bn-l
Copy link
Author

bn-l commented Sep 16, 2017

Hmm, have spent a while now too and it is very hard. Maybe put something in the description to differentiate it.

"0.3 KB JavaScript utility for conditionally concatenating class names."
to
"0.3 KB JavaScript utility for conditionally concatenating CSS class names.

@jorgebucaran
Copy link
Owner

@bn-l Ah, that's a good start, but I still think it's incorrect, because they are not strictly CSS class names.

They can be CSS class names as you say, but in reality you are just building the string that will be used for the className property or [class] attribute.

Maybe "0.3 KB JavaScript utility for conditionally concatenating class names attributes" or change attribute for properties.

Tricky! :)

@loopmode
Copy link

loopmode commented Sep 21, 2017

I think the naming is okay.
Consider that the most popular lib for this is classnames by jedwatson.

Typically I use it like this:

import cx from 'classnames';
...
<div className={cx('foo', 'bar', {baz})}>

Instead, in my next project, I will be doing:

import cw from 'classwrap';
...
<div className={cw(['foo', 'bar', {baz}])}>

So.. I personally think it's just fine now.
You need to be aware of some domain-specific slang in any project. We should already have learned that class and className is not the same thing and what each means :)

@VinSpee VinSpee mentioned this issue Sep 26, 2017
@jorgebucaran jorgebucaran changed the title Classes in JS and css Change name of the library. Oct 23, 2017
@jorgebucaran
Copy link
Owner

@bn-l Hi! I renamed the module to classcat and published 1.0.0. If you were using it, please upgrade. 👋😄

@everdimension
Copy link

What was the original name?

@jorgebucaran
Copy link
Owner

@everdimension The original name was classwrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants