-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name of the library. #5
Comments
@bn-l If you are going to go out of your way to open an issue, you may consider suggesting an alternative name along with your ticket? 🤔 |
Very good point. CssStyleConcat |
StyleWrap I'm spent. I need a cigarette. |
Please remember that this library is pretty much only intended to join class names. For that reason using the word Also spent some time thinking about the name and discussed it with several peers before I published
In the end I chose |
Hmm, have spent a while now too and it is very hard. Maybe put something in the description to differentiate it. "0.3 KB JavaScript utility for conditionally concatenating class names." |
@bn-l Ah, that's a good start, but I still think it's incorrect, because they are not strictly CSS class names. They can be CSS class names as you say, but in reality you are just building the string that will be used for the className property or [class] attribute. Maybe "0.3 KB JavaScript utility for conditionally concatenating class names attributes" or change attribute for properties. Tricky! :) |
I think the naming is okay. Typically I use it like this:
Instead, in my next project, I will be doing:
So.. I personally think it's just fine now. |
@bn-l Hi! I renamed the module to classcat and published 1.0.0. If you were using it, please upgrade. 👋😄 |
What was the original name? |
@everdimension The original name was classwrap. |
Consider changing name. Thought this was something for cond inheritance.
The text was updated successfully, but these errors were encountered: