New ClippingTransforms added #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all, thanks for your help!. I would totally want to merge the PR, but some stuff should be solved before doing that.
And just for the examples that could abstract some info, i think it is pretty much better if we can let it be more explicit even if it means to repeat some code. Dont think about refactoring too much here, but more about readability of the given samples to the user. |
|
Agreed. The build is now passing and I have reverted the refactor to make the code read clearer. |
JorgeCastilloPrz
pushed a commit
that referenced
this pull request
May 13, 2016
Feature/percentage mode
JorgeCastilloPrz
pushed a commit
that referenced
this pull request
May 13, 2016
Coverity Scan found an error: ``` CID 105392 (#1 of 1): Result is not floating-point (UNINTENDED_INTEGER_DIVISION)integer_division: Dividing integer expressions width and 2 * squareSize, and then converting the integer quotient to type double. Any remainder, or fractional part of the quotient, is ignored. ``` The solution is simply to cast one of the arguments to double. This commit does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a couple of additional ClippingTransforms based on your existing ones: SquaresClippingTransform and BitesClippingTransform
Also, I extracted some duplicated code in each of the existing ClippingTransforms into a base class