Fixed Coverity error UNINTENDED_INTEGER_DIVISION #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity Scan found an error: ``` CID 105392 (athkalia#1 of 1): Result is not floating-point (UNINTENDED_INTEGER_DIVISION)integer_division: Dividing integer expressions width and 2 * squareSize, and then converting the integer quotient to type double. Any remainder, or fractional part of the quotient, is ignored. ``` The solution is simply to cast one of the arguments to double. This commit does that.
| @@ -38,7 +38,7 @@ private void cacheDimensions(int width, int height) { | |||
| protected Path buildClippingPath() { | |||
|
|
|||
| Path squaresPath = new Path(); | |||
| int numSquares = (int) Math.ceil(width / (2 * squareSize)); | |||
| int numSquares = (int) Math.ceil((double) width / (2 * squareSize)); | |||
There was a problem hiding this comment.
Did you test the SquareClippingTransform sample demo page after doing this change ? Is it working properly ?
There was a problem hiding this comment.
I went through the application and there was no difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity Scan found an error:
The solution is simply to cast one of the arguments to double. This
commit does that.
This change is