Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any possibility of code exchange? #54

Closed
antonypro opened this issue Apr 30, 2022 · 4 comments
Closed

Any possibility of code exchange? #54

antonypro opened this issue Apr 30, 2022 · 4 comments

Comments

@antonypro
Copy link

@Jorgen-VikingGod: Hi, and thanks for your dark window theme!

I'm here because I'm interested in using your dark theme on my project (https://github.com/antonypro/QGoodWindow) and ask you if you are ok with this, and also ask you if you see any possibility on merge my window with your theme, i think it may covers #1 and #3 goals.

@Jorgen-VikingGod
Copy link
Owner

hi @antonypro thx for the request. Love your QGoodWindow 👍

Sure feel free to embed the DarkStyle to your project/repository - just add somewhere some short credits.

If you have a version with using DarkStyle, let me know - I'm looking forward to test it.

@antonypro
Copy link
Author

@Jorgen-VikingGod: I'm glad that you like my project.

I'm working hard to create a QGoodWindow of yours Dark theme, hence the lack of quick reply to you.

One thing that makes me wonder what is the best method of integration of both projects is the fact that if you accept the merge of your Dark theme with my window you will be introducing a dependency of a stranger into your project, and you maybe not be really happy with this idea.

One option i considered is to maintain your Dark theme in my repository and as you already did, point a link to my project while i do the same with your project.

What do you think? Thanks!

@Jorgen-VikingGod
Copy link
Owner

@antonypro sure, easiest is to embedd the DarkTheme to your repository and mention it 👍

@antonypro
Copy link
Author

@Jorgen-VikingGod: It took a long time until i'm able to release a new version of QGoodWindow with your dark theme. This is finally done and i think this issue could be closed!

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants