Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters with multiple readings #5

Closed
pcdi opened this issue Jan 26, 2018 · 5 comments
Closed

Characters with multiple readings #5

pcdi opened this issue Jan 26, 2018 · 5 comments

Comments

@pcdi
Copy link

pcdi commented Jan 26, 2018

For characters with multiple readings (多音字), only one of the readings is shown.

Example: will be shown only as “to tell to”, and not as “dialect / language / speech”.

However, there is no problem, if the simplified character in question has two different traditional ones, such as , which will be correctly shown as and .

@Kottakji
Copy link
Owner

Thanks for the example! Will look into it when I have time.

Kottakji added a commit that referenced this issue Jan 29, 2018
@Kottakji
Copy link
Owner

This should be fixed in version 2.1.4.

@pcdi
Copy link
Author

pcdi commented Oct 1, 2019

I am sorry to reopen this issue, but I noticed that the behavior is still not as expected. The entry for the character 华, for example, shows only two definitions:

  • [hua1] /old variant of 花[hua1]/flower/
  • [hua2] /magnificent/splendid/flowery/

Whereas the CC–CEDICT contains six definitions, including variants.

@Kottakji
Copy link
Owner

Kottakji commented Oct 5, 2019

Hey @pcdi ,
Thanks for the notification. It seems you are correct. Firefox reverted my 2.1.4 to 2.1.3 some time ago. I will have to look into it and resubmit it after making a few changes. Will try to do it somewhere this month.

@Kottakji Kottakji reopened this Oct 5, 2019
@Kottakji
Copy link
Owner

Kottakji commented Nov 2, 2019

@pcdi I've updated the addon. Thanks for pointing out the problem, and giving a helpful example.

Now, you should see 4 entries for 华. The CC-CEDIT shows 6, but 2 of them are variations. I can't support that right now (I would need a lot more time to).

https://cc-cedict.org/editor/editor.php?handler=QueryDictionary&querydictionary_search=%E5%8D%8E

Closing this issue. Please re-open if you think it's not sufficient yet, or open another issue if there are other problems. Cheers.

@Kottakji Kottakji closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants