Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble - import fails on certain game (simian.interface++) #38

Closed
DragRedSim opened this issue Jun 24, 2021 · 1 comment
Closed

Humble - import fails on certain game (simian.interface++) #38

DragRedSim opened this issue Jun 24, 2021 · 1 comment
Labels
bug Something isn't working humble

Comments

@DragRedSim
Copy link

Describe the bug
Humble plugin fails to import games after a game name breaks the regex parsing. Further information is on the forum at https://playnite.link/forum/thread-722.html .

Based on an analysis of the exact reported error, I suspect the failure is caused at https://github.com/JosefNemec/Playnite/blob/master/source/Plugins/HumbleLibrary/HumbleLibrary.cs#L142 - the string is concatenated with a string containing a regex operation, in order to check for key availability; however, since the game title has the plus symbol in it, the regex match interprets this as the operand, and cannot handle the characters in that context. I suspect that the string being passed requires escaping before adding the operation to the end of the string.

To Reproduce

  1. Have the game simian.interface++ in your Humble account. (Available from https://www.humblebundle.com/store/simianinterface )
  2. Import Humble library to Playnite.
  3. Await error.

Screenshots
https://i.ibb.co/SsFvbpJ/error.png

Diagnostics ID
4ca8085c-2bb6-4334-ac32-d9fa918ccf18

@DragRedSim DragRedSim added the bug Something isn't working label Jun 24, 2021
@JosefNemec
Copy link
Owner

Fixed in 8.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working humble
Projects
None yet
Development

No branches or pull requests

2 participants