Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCS1156 should change (s == "") to (string.IsNullOrEmpty(s)) instead of (s?.Length == 0) #650

Closed
CaerphillyMediaLtd opened this issue Feb 26, 2020 · 2 comments
Closed

RCS1156 should change (s == "") to (string.IsNullOrEmpty(s)) instead of (s?.Length == 0) #650

CaerphillyMediaLtd opened this issue Feb 26, 2020 · 2 comments
Labels
Area-Analyzers Bug

Comments

@CaerphillyMediaLtd
Copy link

RCS1156 suggests changing s == "" to s?.Length == 0, but it should instead change it to string.IsNullOrEmpty(s).

.NET already implements this functionality with the IsNullOrEmpty functionality, I don't think it should be reimplemented using the Length field and a null check. The in-built function also increases readability.
@josefpihrt
Copy link
Collaborator

That makes sense.

@danielabbatt danielabbatt mentioned this issue Apr 8, 2020
Closed
@davidnmbond
Copy link

@josefpihrt - please revert this. It is perfectly valid to compare a string JUST with string.Empty.

josefpihrt added a commit that referenced this issue Apr 8, 2020
@josefpihrt
Revert "Merge analyzer RCS1156 with RCS1113 (fix #650)" (fix #662)
f28a428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Analyzers Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidnmbond @josefpihrt @CaerphillyMediaLtd