-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to swipe once tap is added to the element inside slide. #2
Comments
Hello, I have the same issue, did you find the solution ? Thanks ! |
@ChristelleThiry Not yet, I just disabled the swiping as the tap action is the priority. I've added some timeout that just auto rotates the banner. |
@irman, @ChristelleThiry, @TheOriginalJosh I don't have time to make the changes to the library -- I hope someone else has :-) I change the file SlidesComponent as follows:
You might want to extend the implementation to include the slide ID or something similar. |
Sorry, guy's I've been swamped with some other things. If someone else could Add this I would gladly accept a PR. if not I'll try to add it sometime this week. Thanks. |
Hi,
Nice plugin btw. I'm just having a problem assigning tap event on the slider.
Here's the code:
As you can see, there's
(tap)="getData()"
on theImage
inside theslide
. This will break the slider swipe. How can I prevent this? I've tried moving the(tap)
attribute to theslide
element but that won't trigger any tap event. Any input is appreciated. Thanks!Tested on an Android emulator.
The text was updated successfully, but these errors were encountered: