Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch for pallets frame V2 #458

Open
herou opened this issue Aug 8, 2021 · 5 comments
Open

New branch for pallets frame V2 #458

herou opened this issue Aug 8, 2021 · 5 comments

Comments

@herou
Copy link
Contributor

herou commented Aug 8, 2021

Hi @JoshOrndorff , @jimmychu0807

I was able to convert simple-event pallet into frame v2: https://github.com/herou/recipes/tree/simple_event_frame_v2, the node can run without a problem and I fixed the tests as well.

Simple-map converted: https://github.com/herou/recipes/tree/simple_map_v2 :)
Hello-substrate: https://github.com/herou/recipes/tree/hello_substrate_v2

I would suggest that somebody of you can create a branch that would contain all the pallets that I would convert from frame v1 to frame v2.

If better idea please let me know.

@whereistejas
Copy link

+1 for merging this. This helped me out a lot.

@herou
Copy link
Contributor Author

herou commented Oct 2, 2021

Finally all the pallet are converted from v1 to v2 : https://github.com/herou/recipes/tree/simple_event_frame_v2
@whereistejas
@JoshOrndorff Do you want to check this and why not merging it :)

@JoshOrndorff
Copy link
Owner

I don't maintain this repo anymore, so I don't have power to merge. But I know that the first step is to open a PR. Or PRs if you have two different branches.

@JoshOrndorff
Copy link
Owner

There's no reason anyone wants to keep the old FRAME v1 stuff around, so we should just replace it with your updated versions as you make them.

@JoshOrndorff
Copy link
Owner

This work is merged now, so I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants