-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test modules with ci #71
Comments
For all modules
I agree that we should focus on testing the modules first and then we can address runtimes and the node. |
@gabreal I've now solved all the legitimate build issues with our current CircleCI setup. The build is green, but we're pushing up against the resource limit that we have from CircleCI, and there's still more we'd like to do. In particular, we'd like to confim that the node itself builds, and run unit tests for the modules that provide them. I'm open to continuing to use CircleCI, switch to github actions, gitlab, or something else. I'm also happy to have a video chat if that would be helpful. |
well, afaik there is no paid subscription for circle ci and devops will give support as best as they can but our experience is certainly better with our own ci which is gitlab based. If you want to try out github actions I'm happy to have a look. If you want to have a chat about this pls ping me on riot. |
Issue for devops to migrate CI to gitlab: https://github.com/paritytech/devops/issues/375 |
I'll close this. I'll open another one for "Moving Travis Build and Deploy to Github Actions" and, if/when github actions becomes unusable, we can migrate the CI to gitlab devops as per the referenced devops PR. |
We've agreed in riot that running CI over the modules (and eventually the runtimes and the node) is a good idea. Even before runtime tests are written for the modules, we can at least use CI to ensure they build.
Options for CI pipeline and their strengths are
Travis -- Already used for mdbook portion of recipes
Circle -- Already used by this team for devhub and frontend template
Github actions -- No 3rd party service needed. All stays here in github.
The text was updated successfully, but these errors were encountered: