Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision issue cause problems with many addons, including LFS, Simfphys, ect. #107

Closed
JokerR3310 opened this issue Sep 10, 2022 · 8 comments

Comments

@JokerR3310
Copy link

55555579-=98-89
Both props are set to no-collide with each other, but still continue to interact with each other

the higher the speed the more times they interact with each other, this problem affect not only addons, but anything that uses no-collide.

this problem is also most likely to cause this behavior:

https://steamcommunity.com/sharedfiles/filedetails/?id=2857489430

Main problem:
#86
#28

LFS, Simfphys and other:
#87
#75
#55
#50
#48
#30

@Novar256
Copy link

How to fix that?

@QuoniamVR
Copy link

How to fix that?

Wait for a new release, or fix it in the code.

@barkleygaiden
Copy link

Simfphys/LFS author has created a successor that likely solves this issue https://steamcommunity.com/sharedfiles/filedetails/?id=2912816023

@YUCLing
Copy link

YUCLing commented Jul 25, 2023

I've tried to read the code for half a day, and I came to some conclusions. I'm not familiar with both VPhysics-Jolt and Jolt Physics, so they might be wrong.

The GMod's no collide constraint is made with logic_collision_pair, what it does is add an object hash pair into IPhysicsObjectHashPair (JoltPhysicsObjectHashPair). The VPhysics-Jolt itself doesn't use it at all, it only provides it.

Inside GMod, I can only guess it uses this inside its solver's ShouldCollide. The solver does get called, but there's a problem. Its result doesn't seem to be passed to Jolt Physics. It's being ignored.

As a result, Jolt Physics doesn't know about this, causing the issue.

About the reason for not using the result, I don't know exactly. I can't fix and test it since I don't know much about these things.

@JokerR3310
Copy link
Author

I have high hopes for this
https://github.com/miguelmazetto/gmod_better_vphysics

@Joshua-Ashton
Copy link
Owner

Should be fixed now, previously ShouldCollide was not being respected when linear cast was used.

@Joshua-Ashton Joshua-Ashton closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
@Joshua-Ashton
Copy link
Owner

Also I do not know why you would have high hopes for the exact same physics engine.

The flaws with IVP are pretty fundamental with it's solver and will not be solved by some dude importing a vector math library and trying to optimize things that are not the problem.

@JokerR3310
Copy link
Author

Also I do not know why you would have high hopes for the exact same physics engine.

The flaws with IVP are pretty fundamental with it's solver and will not be solved by some dude importing a vector math library and trying to optimize things that are not the problem.

in such old and ancient engine that based on hundreds hacks and patches just to make it work somehow, it's all about people and ideas, the more people working on something the better for the community. At least He claiming that it will be "original physics engine with performance improvements" with is still milion% better that the original gmod physics if true. But dont get me wrong, you did an amazing job. I still believe one day we will have almost perfect vphysics replica that will allow server owners to unlock true power of modern CPU for server with high amount of players to enjoy without all existing today problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants