Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GMod x64] Crashing on legacy HL2 saving/changelevels #166

Open
Shadowysn opened this issue Jan 25, 2023 · 5 comments · May be fixed by #199
Open

[GMod x64] Crashing on legacy HL2 saving/changelevels #166

Shadowysn opened this issue Jan 25, 2023 · 5 comments · May be fixed by #199

Comments

@Shadowysn
Copy link

Shadowysn commented Jan 25, 2023

Tested with -noaddons and -noworkshop

Saving using the legacy HL2 save file system crashes GMod with Volt physics.
This is significant for the HL2 campaign maps as they make use of logic_autosave which forces saves to be made.
logic_autosave's Save and SaveDangerous inputs, and the save console command were observed to be affected.
The trigger_changelevel entities used often in the campaign maps also crash on attempt to change map.

Extra note: In a quick test of loading save files made with normal VPhysics into Volt, GMod doesn't crash, but physics objects were frozen and physics ragdolls' models were crushed into 0, 0, 0, the map origin.

Crash dumps of both methods just in-case:
crashes.zip

@PiMoNFeeD
Copy link

vanilla vphysics and vphysics jolt save completely different data into the save file, they are not cross-compatible

@Joshua-Ashton
Copy link
Owner

Save files are not compatible.

@Joshua-Ashton Joshua-Ashton closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
@Shadowysn
Copy link
Author

Shadowysn commented Aug 1, 2023

I understand why you may not support legacy save files as it's deprecated by GMod saves, but this issue also extends to autosaving, which occurs regularly in campaign levels with autosave entities without the player's input.
Unless the user is savvy enough to remove the autosave entities either manually or automatically they'll likely find these levels crashing for no reason with VJolt.
If these legacy saves can't be disabled for some reason, a warning would at least suffice.

@Joshua-Ashton
Copy link
Owner

Sorry I thought this issue was about loading regular vphysics saves into vphysics jolt. Regular saving is supported but loading ivp into jolt is not.

@Joshua-Ashton Joshua-Ashton reopened this Aug 1, 2023
@RaphaelIT7 RaphaelIT7 linked a pull request Oct 26, 2023 that will close this issue
2 tasks
@ldx1u
Copy link

ldx1u commented Nov 30, 2023

The same thing happens for legacy HL1 maps aswell, so this hints that many maps that transition to other ones will have the same issue, i wonder if there is a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants