Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace ScenePlayr with a callback #17

Merged
merged 1 commit into from Aug 22, 2022
Merged

feat: replace ScenePlayr with a callback #17

merged 1 commit into from Aug 22, 2022

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 22, 2022 •
edited

Overview

Per #16, replaces the sceneplayr package with a single callback on Library actors.

PR Checklist

  • Fixes Fix Vercel build #1
  • I have run this code to verify it works
  • [ ] This PR includes unit tests for the code change

@vercel
Copy link

vercel bot commented Aug 22, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chooseyourframework ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 4:05PM (UTC)

@JoshuaKGoldberg JoshuaKGoldberg merged commit ab0dc42 into main Aug 22, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the kill-sceneplayr branch August 22, 2022 16:07
@JoshuaKGoldberg JoshuaKGoldberg restored the kill-sceneplayr branch August 22, 2022 19:39
@JoshuaKGoldberg JoshuaKGoldberg deleted the kill-sceneplayr branch August 26, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JoshuaKGoldberg