Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Background music and menu sound effects #25

Open
zernonia opened this issue Aug 26, 2022 · 1 comment
Open

馃殌 Feature: Background music and menu sound effects #25

zernonia opened this issue Aug 26, 2022 · 1 comment
Labels
accepting prs enhancement New feature or request

Comments

@zernonia
Copy link

I know adding sound effect is tricky since the app starts right away, and browser requires user interaction before playing audio.
Not sure "WASD" keypress consider interaction or not 馃

But this is just a "good to have" features 馃榿

@JoshuaKGoldberg JoshuaKGoldberg changed the title Suggestion: Add bgm and/or sound effects 馃殌 Feature: Background music and menu sound effects Aug 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request accepting prs labels Aug 26, 2022
@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Aug 26, 2022

Thanks for suggesting this @zernonia - agreed, audio would be great! WASD keypresses should count, yes - so maybe the background music can fade in when the user first moves?

One more caveat to consider is that the game has a tight (arbitrary, chosen by me on a whim) performance budget of 256 kB total size on the page uncompressed. I suppose we could go over for audio that's lazy-loaded... but whatever audio happens should be very compressed.

EightBittr does have a package already for playing audio: AudioPlayr. https://github.com/FullScreenShenanigans/EightBittr/tree/main/packages/audioplayr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants