fix: graceful recovery for failed spinner step

[JoshuaKGoldberg]

PR Checklist

• Addresses an existing open issue: fixes 🐛 Bug: If a withSpinners step rejects, lines are still written continuously #1016
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Moves the recovery pieces of the withSpinners loop into a finally so they always get called.

[codecov]

Codecov Report

Merging #1017 (6dfa8db) into main (69af9ec) will increase coverage by 0.49%.
Report is 8 commits behind head on main.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   93.64%   94.14%   +0.49%     
==========================================
  Files          93       95       +2     
  Lines        4991     5449     +458     
  Branches      420      436      +16     
==========================================
+ Hits         4674     5130     +456     
- Misses        316      318       +2     
  Partials        1        1              

Flag	Coverage Δ
create	70.87% <76.47%> (+<0.01%)	⬆️
initialize	41.16% <76.47%> (+2.81%)	⬆️
migrate	69.86% <76.47%> (+0.10%)	⬆️
unit	71.57% <0.00%> (+2.59%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/shared/cli/spinners.ts	84.72% <76.47%> (+1.62%)	⬆️

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[github-actions]

🎉 This is included in version v1.43.2 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀