Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃洜 Tooling: semantic-release isn't creating git commits #103

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 13, 2022 · 1 comment 路 Fixed by #104
Closed
3 tasks done

馃洜 Tooling: semantic-release isn't creating git commits #103

JoshuaKGoldberg opened this issue Dec 13, 2022 · 1 comment 路 Fixed by #104
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

As of #102, the semantic-release bot isn't committing the dist/ directory to git (#63)... but it's not committing anything!

I think assets should be ['package.json'], not []. Because I do want package.json to be committed.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Dec 13, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 13, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 13, 2022
Merged
3 tasks
@github-actions
Copy link

馃帀 This issue has been resolved in version 1.4.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: include package.json in semantic-release/git JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg