Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infer --guide-title #1138

Merged
merged 2 commits into from
Dec 30, 2023
Merged

fix: infer --guide-title #1138

merged 2 commits into from
Dec 30, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Fills in a missing values['guide-title']. Sigh.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81a9f98) 94.25% compared to head (1cd9b86) 94.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1138   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          97       97           
  Lines        5625     5626    +1     
  Branches      454      454           
=======================================
+ Hits         5302     5303    +1     
  Misses        322      322           
  Partials        1        1           
Flag Coverage Δ
create 70.22% <100.00%> (+<0.01%) ⬆️
initialize 42.16% <100.00%> (+0.01%) ⬆️
migrate 69.56% <100.00%> (+<0.01%) ⬆️
unit 72.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d316737 into main Dec 30, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the infer-guide-title branch December 30, 2023 08:47
Copy link

🎉 This is included in version v1.50.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: --guide-title is ignored when --guide is provided
1 participant