Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include bin entry in package.json files #1149

Merged
merged 3 commits into from
Dec 30, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Includes a files entry if bin exists. Also strips a preceding ./ from it if it's there.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aaad5ae) 94.28% compared to head (582d9e7) 94.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files          97       97           
  Lines        5631     5637    +6     
  Branches      457      458    +1     
=======================================
+ Hits         5309     5315    +6     
  Misses        321      321           
  Partials        1        1           
Flag Coverage Δ
create 70.26% <85.71%> (+0.01%) ⬆️
initialize 42.15% <0.00%> (-0.05%) ⬇️
migrate 69.66% <100.00%> (+0.03%) ⬆️
unit 72.35% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 206c835 into main Dec 30, 2023
16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the package-json-files-bin branch December 30, 2023 14:20
Copy link

🎉 This is included in version v1.51.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: package.json files array should include bin entry
1 participant